Progress bar defaults to 80 character length when ran through Spring on Rails

[brandonweiss]

I've been working on improving the ProgressReporter on minitest-reporters, and I recently switched it from using PowerBar to ruby-progressbar. This fixed a performance issue and enabled a few other improvements, but I noticed an issue minitest-reporters/minitest-reporters#106.

As I mentioned in the issue I read through LengthCalculator but my knowledge of how terminals work isn't deep enough to understand why this is happening or if there's a fix, and if that fix should be on ruby-progressbar or not. Thoughts?

[jfelchner]

@brandonweiss there are multiple places where it gives up and defaults to 80 characters. If you could add some puts statements locally to figure out which one is actually being fired, that would help a lot in tracking down exactly what's going on.

[brandonweiss]

Ah, OK, what seems to be happening is IO.console is nil, so when winsize is called on it an exception is raised, which is rescued and returns 80 in terminal_width.

[jfelchner]

@brandonweiss my guess (and I don't know this for a fact) is that spring is buffering the output through its own IO object first, then it's outputting it to the screen.

Because of this, the bar has no console with which to check it's width.

Your only option for a full width bar at that point would be to manually set the ENV variable that progressbar checks before it does it's calculation.

[jfelchner]

@brandonweiss I'm going to leave this issue open as long as it's still being researched. I want to make sure it's not a problem with ruby-progressbar. Let me know what you find.

[brandonweiss]

Yeah I'm researching it now. Will do!

[jfelchner]

Also, off the subject, but just wait till you see what I have in store for the next version of the gem. 😄 It'll be especially applicable to a test reporter.

I'm going to add "buckets" to the bar. So that you'll essentially be able to do something like this:

|++++++=======--------->                           |

Where the '+' might be a red =, the "=" might be a yellow = and the "-" might be a green =. Allowing you to visually see a rough percentage of failed/pending/successful tests.

[brandonweiss]

Yes! I was initially trying to do that, until I realized that it's not possible in the way a normal reporter with dots can do it, because the bar is redrawn every time. So I settled for the whole bar changing color. But it would certainly be awesome to be able to colorize part of it.

[jfelchner]

Hey @brandonweiss any progress on this?

[brandonweiss]

Sorry, I've got an issue open (rails/spring#296) on spring, I just haven't heard back yet.

[jfelchner]

@brandonweiss awesome. No problem. Tell ya what, I'm going to close this issue for now since it's not really an issue with the progressbar. If/when they get back to you, just ping me back on this issue and I'll reopen in.

[brandonweiss]

👍

[qd3v]

Just if someone needs a temporary solution (this is guard+rspec+spring+fuubar on OS X example):

guard :rspec, cmd: 'RUBY_PROGRESS_BAR_LENGTH=`tput cols` bin/rspec' do
end

or add this line in bin/rspec

#!/usr/bin/env ruby
begin
  ENV['RUBY_PROGRESS_BAR_LENGTH'] ||= `tput cols`.chomp # <---
  load File.expand_path("../spring", __FILE__)
rescue LoadError
end
require 'bundler/setup'
load Gem.bin_path('rspec-core', 'rspec')

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.