feat(types): add typings for defaultAsComponent: true case.
#25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seahindeniz
reviewed
Jun 4, 2023
README.md
Outdated
| "types": [ | ||
| "vite/client", | ||
| "vite-plugin-solid-svg/types", | ||
| // Use vite-plugin-solid-svg/types-default together with `defaultAsComponent` |
There was a problem hiding this comment.
Maybe vite-plugin-solid-svg/as-component?
There was a problem hiding this comment.
Sounds nice, but for consistency will use component-solid.
MrFoxPro
force-pushed
the
default-as-component-types
branch
2 times, most recently
from
b3c1f17
to
601451a
Compare
MrFoxPro
force-pushed
the
default-as-component-types
branch
from
601451a
to
d34519a
Compare
|
@jfgodoy let's publish it |
|
great work!! 🎉 I've just published it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#24