fixes to DELETE method handling #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the if-block for deleting an object from a relation was not committing; the tests were still passing because the session was still open and the next API call would pull the object out of the session, not the DB. Put a `session.remove()` before the API call to check that the removed object is actually gone from the relation, and you'll see that it's still there in the DB.
Idempotency only means that subsequent identical requests cannot have additional side-effects. Since the response code is not a side effect, but rather a return value, `DELETE` should respond with `204` only if an object is deleted, and with `404` when nothing is deleted. (It is very confusing if an API returns `204` to a DELETE for a nonexistent or inaccessible resource.)
|
Okay, I misunderstood the RFC :) Again, I am not an expert, so thanks for double checking me on this. |
jfinkels
added a commit
that referenced
this pull request
Jul 15, 2014
fixes to DELETE method handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
session.remove()before the API call to check that the removed object is actually gone from the relation, and you'll see that it's still there in the DB.additional side-effects. Since the response code is not a side effect,
but rather a return value,
DELETEshould respond with204only ifan object is deleted, and with
404when nothing is deleted.(It is very confusing if an API returns
204to a DELETE for a nonexistentor inaccessible resource.)