don't bother with count() if a limit has already been set #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the constructed query for count below strips off any limit and offset, and if limit is specified without offset, it returns the whole count, not the limited count.
|
As with previous pull requests, the build on the upstream repository has passed, https://travis-ci.org/goodscloud/flask-restless/builds/28818595 indicating a problem with the travis cache on the master branch in jfinkels/flask-restless causing the pre-merge build to fail under pypy. |
|
I merged a different solution to this, I think, from pull request #333. Which one is better? |
|
#333 is better, if you notice that one adds a third test, where |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the constructed query for count below strips off any limit and offset, and if limit is specified without offset, it returns the whole count, not the limited count.