Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grep Path incorrect. #229

Open
kaukas opened this issue Jul 1, 2016 · 1 comment
Open

Grep Path incorrect. #229

kaukas opened this issue Jul 1, 2016 · 1 comment

Comments

@kaukas
Copy link
Contributor

kaukas commented Jul 1, 2016

Hello.

Thank you for the very useful testing framework! I am relying on it to test some complex frontend code.

I have one issue with the links to suites. To the right of every test Mocha displays a link to a page that runs just that test (a triangle within a circle). The URL is incorrect though. E.g. if I run the /models tests and then want to test a Book model it will link to /models/book_spec/models/?grep=Book. Instead it should be /models/book_spec/?grep=Book. I think it has to do with the grepString variable in konacha/parent.js file. Besides storing the ?grep=Book part it also has the current path: /models/?grep=Book. This part needs to be filtered out. Adding

grepString = grepString.substr(grepString.indexOf('?'));

fixes the problem for me.

Am I the only one with this problem? If not should I make a PR?

Thank you!

@kaukas
Copy link
Contributor Author

kaukas commented Jul 14, 2016

The fix does not work on IE8. I will look for a solution and comment again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant