Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
José,
Here's my proposal. We deprecate version 1.x and come out with a 2.0 with the following breaking changes:
react-responsive-render-if
.react-responsive-render-if
.export default
, which is a more standard way of exporting React components.tag
becomesmasqueradeAs
.ResponsiveRenderIf
(see README). We could go with simplyRenderIf
.Oh, you originally wanted a
notag
option. I've made this unnecessary as I only render a containing element when any of the following are true:masqueradeAs
prop was specified.query
ormasqueradeAs
.All this is up for discussion. It's your baby. I'll re-submit a proper PR once we've discussed.
Also, my intent is to publish the first version as "alpha" we we can play with it on codepen before we publish a "real" 2.0.0. This will save us the embarrassment in case we get anything wrong.