Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding tvOS support in UIKit extensions #62

Closed
wants to merge 1 commit into from
Closed

adding tvOS support in UIKit extensions #62

wants to merge 1 commit into from

Conversation

romainbiard
Copy link

Hello,
I just had to extend the compiler check to be able to work with tvOS.
Great pod BTW, loving it !

Thanks,
Romain

adding tvOS support in UIKit extensions
@romainbiard romainbiard mentioned this pull request May 11, 2017
@jflinter
Copy link
Owner

This isn't sufficient to add tvOS support. At the bare minimum,

  • You need to actually add a scheme to the xcodeproj to make sure that the project actually builds for tvOS.
  • This scheme must be built and tested during travis builds.
  • The .podspec must be updated to indicate that tvOS is supported.

@jflinter jflinter closed this May 11, 2017
@romainbiard
Copy link
Author

Ok since tvOS support was already in the podspec I assumed it was only this class which needs a quick update. Give me a few minute to reopen a new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants