-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coordinates #1
base: master
Are you sure you want to change the base?
Coordinates #1
Conversation
…e parameter either in little-endian or big-endian encoding.
Thanks, Andrei. It has been so long since I looked at this project. I know a lot of things are out of date. I'll try to have a look. One thing I'll say is we should try to use C# idioms / naming conventions. So we don't typically have names that are all caps or have underscores. Have a look at: https://learn.microsoft.com/en-us/dotnet/csharp/fundamentals/coding-style/coding-conventions Do you have any small sample SEGY files you can provide that are good test cases for your new features? Thanks for your contribution. |
Most definitely I have some SEGY files. Will try to find some time over the weekend. |
Hi, @Andrei-Errapart, sorry your PR has languished for so long. My consulting work always takes precedence. I'd like to spend a few cycles getting this project back up to date with .NET if it is still useful to you. Was this something you are using for research? Or commercial use? If commercial, would your employer be willing to sponsor a day's work? Cheers. |
Hi, no need to apologize, the ball was on my side and I haven't had the time for it. It was used just to convert some files. Some further work was anticipated but it didn't realize. Thus, I haven't done anything with SGY since then. Were we still actively involved with the SGY format, arranging compensation for the work would be feasible. In the foreseeable future, no. I personally think that if one just wants to practice his/her coding/sw engineer skills, using UnpluggedSegy as a practice target makes sense - the possible failures impact a few people. |
This is my first pull request over who knows how many years. All comments are welcome.
There are fields for the X,Y coordinates in TraceHeader and ITraceHeader now.
The library has been updated to use PackageReferences as does everyone these days.
Speed optimization of about 2x. This is noticeable when reading from NVME disks.