Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customize commit email author #377

Merged
merged 4 commits into from
Jul 6, 2023
Merged

Customize commit email author #377

merged 4 commits into from
Jul 6, 2023

Conversation

omerzi
Copy link
Member

@omerzi omerzi commented Jul 4, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • The default commit author in Frogbot is eco-system+frogbot@jfrog.com, this pull request introduces the abiility to change the commit author with the JF_GIT_EMAIL_AUTHOR env or emailAuthor field in the frogbot-config file.

@omerzi omerzi requested a review from eyalbe4 July 4, 2023 05:29
@omerzi omerzi removed the request for review from eyalbe4 July 4, 2023 05:30
@omerzi omerzi requested a review from eyalbe4 July 4, 2023 05:38
@omerzi omerzi added safe to test Approve running integration tests on a pull request new feature Automatically generated release notes labels Jul 4, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

eyalbe4
eyalbe4 requested changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@eyalbe4 eyalbe4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that the new variable is missing from the following template files -

install-azure-repos.md
install-bitbucket-server.md
install-github.md
install-gitlab.md

@omerzi
Copy link
Member Author

omerzi commented Jul 5, 2023

I noticed that the new variable is missing from the following template files -

install-azure-repos.md
install-bitbucket-server.md
install-github.md
install-gitlab.md

Done

@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Jul 5, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

@omerzi omerzi merged commit 78b006b into jfrog:dev Jul 6, 2023
6 of 7 checks passed
@omerzi omerzi deleted the add-git-email-author branch July 6, 2023 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 requested changes

Assignees
No one assigned
Labels
new feature Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@omerzi @eyalbe4