Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send detected secrets by email #438

Merged
merged 24 commits into from
Aug 15, 2023
Merged

Send detected secrets by email #438

merged 24 commits into from
Aug 15, 2023

Conversation

omerzi
Copy link
Member

@omerzi omerzi commented Aug 14, 2023 •
edited

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

@omerzi omerzi added safe to test Approve running integration tests on a pull request new feature Automatically generated release notes labels Aug 14, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 14, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Aug 14, 2023
@omerzi omerzi requested a review from sverdlov93 August 14, 2023 14:21
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 14, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Aug 14, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 14, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Aug 15, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 15, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Aug 15, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 15, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Aug 15, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 15, 2023
sverdlov93
sverdlov93 reviewed Aug 15, 2023
View reviewed changes
commands/scanpullrequest/scanpullrequest.go Outdated Show resolved Hide resolved
commands/scanpullrequest/scanpullrequest.go Outdated Show resolved Hide resolved
commands/scanpullrequest/scanpullrequest.go Outdated Show resolved Hide resolved
commands/scanpullrequest/scanpullrequest.go Outdated Show resolved Hide resolved
commands/utils/params_test.go Outdated Show resolved Hide resolved
commands/utils/utils.go Outdated Show resolved Hide resolved
docs/install-gitlab.md Outdated Show resolved Hide resolved
docs/install-gitlab.md Outdated Show resolved Hide resolved
commands/utils/consts.go Outdated Show resolved Hide resolved
docs/install-gitlab.md Outdated Show resolved Hide resolved
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Aug 15, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 15, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Aug 15, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 15, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Aug 15, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 15, 2023
@github-actions
Copy link
Contributor

@omerzi omerzi merged commit 1fc9bd2 into jfrog:dev Aug 15, 2023
6 of 7 checks passed
@omerzi omerzi deleted the add-email-for-secrets branch August 15, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sverdlov93 sverdlov93 sverdlov93 left review comments

Assignees
No one assigned
Labels
new feature Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@omerzi @sverdlov93