Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create multi scan id before running audit command #633

Merged
merged 7 commits into from
Feb 15, 2024

Conversation

orz25
Copy link
Contributor

@orz25 orz25 commented Feb 4, 2024

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Add a call to xsc git info api before running audit in order to have one multi scan id to multiple sca scans (we send a scan request per technology and we wish to associate all the scans to one multi scan id).

PRs for client-go and cli-security:
clent-go: jfrog/jfrog-client-go#898
cli-security: jfrog/jfrog-cli-security#20

@attiasas attiasas added safe to test Approve running integration tests on a pull request improvement Automatically generated release notes labels Feb 5, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 5, 2024
@orz25 orz25 changed the title Add a call to xsc git info api before running audit Create multi scan id before running audit command Feb 5, 2024
@attiasas attiasas self-requested a review February 8, 2024 11:54
Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about adding the multiscanid for scanning Pull requests? you didn't take into account this command with your changes.

@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Feb 15, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 15, 2024
Copy link
Contributor

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.


@attiasas attiasas merged commit 1b0e584 into jfrog:dev Feb 15, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants