Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Severity Field for Licenses Violations for Pull Request Scans #672

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

imranzunzani
Copy link
Contributor

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • Update documentation about new features / new supported technologies

Description:

This PR is to add 'Severity' classification to the License Violations' information, for the Pull Request Scan Results. It is related to the issue: #666, as it helps with resolving one aspects discussed in that issue, which is for PR Scans.
This functionality is helpful to differentiate among the levels of violations, for developers to act on, while working on PRs.

It adds the column for 'Severity' as shown in the below screenshot:
violated-licenses

This image has been added in the change, to update it as it is referenced in the documentation.

Copy link
Contributor

github-actions bot commented Mar 31, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@imranzunzani
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@attiasas attiasas added safe to test Approve running integration tests on a pull request improvement Automatically generated release notes labels Apr 1, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 1, 2024
@imranzunzani
Copy link
Contributor Author

Hi @attiasas ,
Does this require modifications, or is good to approve?

Copy link
Contributor

github-actions bot commented Apr 9, 2024

👍 Frogbot scanned this pull request and did not find any new security issues.


@attiasas attiasas self-requested a review April 9, 2024 08:40
Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this change will only affect scan-pull-request command.

@attiasas attiasas added bug Something isn't working safe to test Approve running integration tests on a pull request and removed improvement Automatically generated release notes labels Apr 9, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 9, 2024
@attiasas attiasas merged commit 1098871 into jfrog:dev Apr 9, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants