Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modifications to RunMavenDepTree and Maven dependency tree construction #1115

Merged
merged 7 commits into from
Jan 25, 2024
Merged

Modifications to RunMavenDepTree and Maven dependency tree construction #1115

merged 7 commits into from
Jan 25, 2024

Conversation

eranturgeman
Copy link
Contributor

@eranturgeman eranturgeman commented Jan 23, 2024 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

This pull request brings changes and refactoring related to the execution of the maven-dep-tree plugin. All affected functions have also been modified.

@eranturgeman eranturgeman added the ignore for release Automatically generated release notes label Jan 23, 2024
@eranturgeman
Merge branch 'dev' of https://github.com/jfrog/jfrog-cli-core into mo…
844bc67 
…dification-concerning-buildDepTree-with-maven-plugin
sverdlov93
sverdlov93 reviewed Jan 24, 2024
View reviewed changes
utils/java/mvn.go Outdated Show resolved Hide resolved
attiasas
attiasas reviewed Jan 24, 2024
View reviewed changes
utils/java/mvn_test.go Outdated Show resolved Hide resolved
attiasas
attiasas reviewed Jan 24, 2024
View reviewed changes
Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure to add description to the PR

@github-actions GitHub Actions
Copy link
Contributor

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.

@eranturgeman eranturgeman changed the title Modifications to Maven dependency tree construction related to RunMavenDepTree changes Modifications to RunMavenDepTree and Maven dependency tree construction Jan 25, 2024
@eranturgeman eranturgeman merged commit aac01c1 into jfrog:dev Jan 25, 2024
8 checks passed
@eranturgeman eranturgeman mentioned this pull request Jan 25, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sverdlov93 sverdlov93 sverdlov93 left review comments

@attiasas attiasas attiasas left review comments

Assignees
No one assigned
Labels
ignore for release Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eranturgeman @sverdlov93 @attiasas