Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven - enable dependencies resolution from Artifactory server in scan-repository #623

Merged
merged 9 commits into from
Jan 25, 2024

Conversation

eranturgeman
Copy link
Contributor

@eranturgeman eranturgeman commented Jan 23, 2024

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

This PR introduces a bug fix in Maven UpdateDependency flow and now we can resolve dependencies from Artifactory upon fix during scan-and-fix flow.
dependes on: jfrog/jfrog-cli-core#1115, jfrog/jfrog-cli-core#1116

@eranturgeman eranturgeman added bug Something isn't working safe to test Approve running integration tests on a pull request labels Jan 23, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 23, 2024
packagehandlers/packagehandlers_test.go Outdated Show resolved Hide resolved
packagehandlers/mavenpackagehandler.go Outdated Show resolved Hide resolved
packagehandlers/mavenpackagehandler.go Outdated Show resolved Hide resolved
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Jan 24, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 24, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Jan 25, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 25, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Jan 25, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 25, 2024
Copy link
Contributor

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.


@eranturgeman eranturgeman changed the title Settings.xml missing fix Maven - enable dependencies resolution from Artifactory server in scan-repository Jan 25, 2024
@eranturgeman eranturgeman merged commit 76f3667 into jfrog:dev Jan 25, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants