Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New JFrog Pipelines commands #1766

Merged
merged 25 commits into from
Jan 26, 2023
Merged

New JFrog Pipelines commands #1766

merged 25 commits into from
Jan 26, 2023

Conversation

bhanurp
Copy link
Collaborator

@bhanurp bhanurp commented Nov 24, 2022 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

@bhanurp bhanurp temporarily deployed to frogbot January 5, 2023 05:02 — with GitHub Actions Inactive
yahavi
yahavi requested changes Jan 8, 2023
View reviewed changes
Copy link
Member

@yahavi yahavi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bhanurp!

  1. Please make sure to have all comments started in a capital letter
  2. Please consider my guidelines and apply them in all other places in the code

We'll review it again after that.

docker_test.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
pipelines/cli.go Outdated Show resolved Hide resolved
pipelines/config.go Outdated Show resolved Hide resolved
utils/cliutils/commandsflags.go Outdated Show resolved Hide resolved
pipelines/sync.go Outdated Show resolved Hide resolved
pipelines/sync.go Outdated Show resolved Hide resolved
pipelines/systeminfo.go Outdated Show resolved Hide resolved
utils/cliutils/cli_consts.go Outdated Show resolved Hide resolved
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Jan 8, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 8, 2023
@eyalbe4 eyalbe4 changed the title Added pipelines run status and trigger run New Pipelines run status and trigger run commands Jan 25, 2023
@eyalbe4 eyalbe4 added the new feature Automatically generated release notes label Jan 25, 2023
@eyalbe4 eyalbe4 changed the title New Pipelines run status and trigger run commands New JFrog Pipelines commands Jan 25, 2023
eyalbe4
eyalbe4 requested changes Jan 25, 2023
View reviewed changes
docs/pipelines/status/help.go Outdated Show resolved Hide resolved
docs/pipelines/syncstatus/help.go Outdated Show resolved Hide resolved
docs/pipelines/sync/help.go Outdated Show resolved Hide resolved
docs/pipelines/trigger/help.go Outdated Show resolved Hide resolved
docs/pipelines/trigger/help.go Outdated Show resolved Hide resolved
pipelines/cli.go Outdated Show resolved Hide resolved
pipelines/cli.go Outdated Show resolved Hide resolved
pipelines/runstatus.go Outdated Show resolved Hide resolved
pipelines/sync.go Outdated Show resolved Hide resolved
pipelines/cli.go Show resolved Hide resolved
@eyalbe4 eyalbe4 added the safe to test Approve running integration tests on a pull request label Jan 25, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 25, 2023
@bhanurp bhanurp requested review from eyalbe4 and yahavi and removed request for yahavi and eyalbe4 January 26, 2023 05:40
eyalbe4
eyalbe4 requested changes Jan 26, 2023
View reviewed changes
docs/pipelines/syncstatus/help.go Outdated Show resolved Hide resolved
@bhanurp bhanurp requested a review from eyalbe4 January 26, 2023 09:54
@eyalbe4 eyalbe4 added the safe to test Approve running integration tests on a pull request label Jan 26, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 26, 2023
@eyalbe4 eyalbe4 merged commit 821a92b into jfrog:dev Jan 26, 2023
sarao1310 pushed a commit to sarao1310/jfrog-cli that referenced this pull request Apr 17, 2023
@bhanurp @sarao1310
New JFrog Pipelines commands (jfrog#1766)
71df877
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi yahavi requested changes

@eyalbe4 eyalbe4 Awaiting requested review from eyalbe4

Assignees
No one assigned
Labels
new feature Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bhanurp @eyalbe4 @yahavi