Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't upload a directory if its name includes '()' #678

Merged
merged 45 commits into from
Dec 18, 2022
Merged

Can't upload a directory if its name includes '()' #678

merged 45 commits into from
Dec 18, 2022

Conversation

gailazar300
Copy link
Contributor

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Fixes this issue: jfrog/jfrog-cli#1658

@gailazar300 gailazar300 added the bug Something isn't working label Dec 1, 2022
@gailazar300 gailazar300 temporarily deployed to frogbot December 1, 2022 16:52 Inactive
@eyalbe4 eyalbe4 changed the title Fix: can't upload a folder whose name includes '()' Can't upload a folder if its name includes '()' Dec 1, 2022
@eyalbe4 eyalbe4 added the safe to test Approve running integration tests on a pull request label Dec 1, 2022
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

What is Frogbot?

eyalbe4
eyalbe4 requested changes Dec 1, 2022
View reviewed changes
utils/parenthesesutils.go Outdated Show resolved Hide resolved
utils/parenthesesutils.go Outdated Show resolved Hide resolved
utils/utils.go Outdated Show resolved Hide resolved
utils/utils.go Outdated Show resolved Hide resolved
utils/utils.go Outdated Show resolved Hide resolved
utils/utils.go Outdated Show resolved Hide resolved
utils/utils.go Outdated Show resolved Hide resolved
utils/utils.go Outdated Show resolved Hide resolved
utils/utils.go Show resolved Hide resolved
@gailazar300 gailazar300 added the safe to test Approve running integration tests on a pull request label Dec 15, 2022
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 15, 2022
@gailazar300 gailazar300 added the safe to test Approve running integration tests on a pull request label Dec 15, 2022
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 15, 2022
@gailazar300 gailazar300 added the safe to test Approve running integration tests on a pull request label Dec 15, 2022
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 15, 2022
@gailazar300 gailazar300 added the safe to test Approve running integration tests on a pull request label Dec 16, 2022
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 16, 2022
@gailazar300 gailazar300 added the safe to test Approve running integration tests on a pull request label Dec 16, 2022
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 16, 2022
eyalbe4
eyalbe4 requested changes Dec 16, 2022
View reviewed changes
artifactory/services/upload.go Outdated Show resolved Hide resolved
utils/parenthesesutils.go Outdated Show resolved Hide resolved
utils/parenthesesutils.go Outdated Show resolved Hide resolved
utils/parenthesesutils.go Outdated Show resolved Hide resolved
utils/parenthesesutils.go Outdated Show resolved Hide resolved
utils/utils.go Outdated
// Returns the higher index between all placeHolders target instances.
// Example: for input "{1}{5}{3}" returns 5.
func getMaxPlaceholderIndex(toReplace string) (int, error) {
reg, err := regexp.Compile(`\{(\d+?)}`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're compiling here a constant regexp (which never changes), we should compile it only once. This is because compiling regular expressions is an expensive operation.

artifactory/services/download.go Outdated Show resolved Hide resolved
@eyalbe4 eyalbe4 changed the title Can't upload a folder if its name includes '()' Can't upload a directory if its name includes '()' Dec 16, 2022
@gailazar300 gailazar300 added the safe to test Approve running integration tests on a pull request label Dec 18, 2022
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 18, 2022
@gailazar300 gailazar300 added the safe to test Approve running integration tests on a pull request label Dec 18, 2022
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 18, 2022
@gailazar300 gailazar300 merged commit 3da1aa2 into jfrog:dev Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 requested changes

@yahavi yahavi yahavi requested changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gailazar300 @eyalbe4 @yahavi