enable user to update baud of configured Serial port #107
Conversation
|
@dtex please test in your GPS code with firmata/arduino#270 |
| * @param {number} portId The serial port to update the baud of. | ||
| * @param {number} newBaud The new baud rate to set. | ||
| */ | ||
| Board.prototype.serialBaud = function(portId, newBaud) { |
There was a problem hiding this comment.
an alternate name could be serialUpdateBaud to avoid any confusion as to whether or not this sets the initial baud or is used only for updating the baud rate.
There was a problem hiding this comment.
Should also check that the Firmata protocol version is at least 2.6.
|
Might the delay vary across platforms? Do we want to add an optional callback in the signature so the users can just think about that? |
|
I'm not sure if the delay will be necessary or will vary on non-arduino platforms since I only really use arduino. |
|
@dtex @soundanalogous any further testing needed or is this ready to go? |
|
This is not ready. It may be some time as I still need to revise at the protocol level. |
|
I'm going to redo this in SerialFirmata v2.0 |
The delay here could be tricky. Users have to understand that if they call
board.serialBaud(newBaudRate)they will need to wait at least 200ms before they can write to the serial port.The delay is necessary for updating the baud rate for HW serial. There is actually no delay (other than the time required to transmit the command to the Arduino) for SW serial, but it's probably easier to say the delay exists regardless.