expose sampling interval #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Board.prototype.getSamplingInterval = function(interval) { | ||
| return this.settings.samplingInterval; | ||
| }; | ||
|
|
There was a problem hiding this comment.
Notes:
- I'd rather not perpetuate the pattern of naming methods
getFooandsetFoo.setSamplingIntervalwas added before I took on maintainership and it's an eye sore. I'm not sure what to do about it now, if anything. I probably have to just accept it. - If no
samplingIntervalis specified, this will returnundefineduntil some code callssetSamplingInterval(...), but that's not correct, since the default is 19ms. AddsamplingInterval: 19tovar defaults = {(line 377)
There was a problem hiding this comment.
+1 to ditching the get and set style.
- Would it make sense to deprecate
setSamplingIntervaland add a fluent stylesamplingInterval? - Done
| */ | ||
|
|
||
| Board.prototype.getSamplingInterval = function(interval) { | ||
| return this.settings.samplingInterval; |
There was a problem hiding this comment.
I should probably add a way to query the sampling interval in Firmata. I'm not sure about J5 / node-firmata, but some Firmata client's enable multiple connections to a single board (more common when using networking transports rather than serial). In this case, one client could set the sampling interval but another client would not know it has changed.
|
Published to v0.5.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be useful to query the state of the board and set timers based on the query interval. Potential use case would be to shim
requestAnimationFrameto sync with the board query interval.