API calls for Clan command #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @jgayfer I've updated the README |
|
@PhillypHenning last but not least, it would be great if you could add some integration tests for the end points you added. You see can see how I have them setup in the tests folder. I'm not doing anything terribly fancy - just making a request with proper values to ensure that we aren't getting an error code. It basically just serves as a nice way to ensure that we're playing nice with Bungie's API! :) |
|
Awesome work! Really like the refactoring of the integrations tests :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding new callers for the Destiny2 API
Context
The new clan command that is being added to Spirit requires access to additional Destiny2 API endpoints and manifest information.
How Has This Been Tested?
I have tested it locally with success but further testing needed.
Screenshots :
Successful output
Types of changes
New entry points into the Destiny2 API
Checklist: