Cyclic dependency check not needed.

jglick · Nov 16, 2011 · 40806bb · 40806bb
1 parent a9be16e
commit 40806bb
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/core/src/main/java/hudson/PluginManager.java b/core/src/main/java/hudson/PluginManager.java
@@ -335,7 +335,8 @@ public void dynamicLoad(File arc) throws Exception {
         if (getPlugin(p.getShortName())!=null)
             throw new IllegalArgumentException("Dynamic reloading isn't possible");
 
-        // TODO: check cyclic dependency
+        // there's no need to do cyclic dependency check, because we are deploying one at a time,
+        // so existing plugins can't be depending on this newly deployed one.
 
         plugins.add(p);
         activePlugins.add(p);