[JENKINS-4409] Disable URLClassLoader cache before opening stream #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements a workaround for https://bugs.openjdk.java.net/browse/JDK-8013099 The previous behaviour was causing retention of file handles, resulting in temp folder leaks when executing Jenkins test cases.
|
Jesse Glick » sezpoz #18 SUCCESS |
|
This seems problematic. For the normal case that JARs are not changing “beneath your feet”, it will result in worse performance, since the JAR might need to be closed and reopened for each lookup. And it probably only matters on Windows in practice. I think it is less controversial to just disable caches globally during tests on Windows, leaving Linux and production systems untouched. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements a workaround for https://bugs.openjdk.java.net/browse/JDK-8013099
The previous behaviour was causing retention of file handles, resulting
in temp folder leaks when executing Jenkins test cases.