Remove extra soft break for tasklist

[black-desk]

Browser will display the extra newline character between checkbox and
text as a space, which make tasklist items cannot be aligned.

I just remove it.

before:

after:

[jgm]

This seems a good change! We need tests to be updated before CI will pass.

[jgm]

Thanks!

[mb21]

But usually you would want space between the check-mark and the text?

Also, pandoc markdown was according to GitHub Markdown spec before this PR: https://github.github.com/gfm/#task-list-items-extension-

[black-desk]

I think the space between text and box should be done by css but not literal space, just like normal list item:

[tarleb]

I think the space between text and box should be done by css but not literal space.

Agreed, but this brings us into a dilemma: either we break compatibility with the GFM spec that gave rise to this feature, or we produce overly-specific HTML.

My preference is with keeping this PR, but the choice should be an informed decision.

[black-desk]

My preference is with keeping this PR, but the choice should be an informed decision.

Agreed, but I not familiar with Haskell at all. I not even understand the line I changed :(

Sorry, I cannot help :(

[tarleb]

No worries. What I mean is just that it's important to discuss the issue that @mb21 brought up. From my point of view, there are no further changes necessary.

[jgm]

Thanks for bringing this up, I hadn't considered this possible drawback.
I think it's okay if our HTML output departs slightly from GitHub's as long as semantically it's the same. However, we do want to ensure that there's a space between the check box and the text. Could we add something to our default CSS for this?

[black-desk]

the screenshots I show in #8142 (comment) had apply my own css:

input[type="checkbox"] {
        margin-right:0;
        margin-left: -1.5em;
        width: 1.5em;
}

the default situation is weird:

because the checkbox is part of the <p>, and pandoc's css set:

ul.task-list{list-style: none;}

:(

but in my option of view, the checkbox is some kind of ::marker which should be a sibling of <p>

---

Update:

cmark-gfm's html output of

- [ ] aaa

  aaa

  aaa

is

md render api of github return:

so this is a bug of pandoc's tasklist ext :)

---

by the way github's css here:

[jgm]

OK, that makes sense. Maybe we should have a separate issue (since this PR is now closed) suggesting making the checkbox a sibling of the block-level content, and suggesting some default CSS for it?

[black-desk]

OK, that makes sense. Maybe we should have a separate issue (since this PR is now closed) suggesting making the checkbox a sibling of the block-level content, and suggesting some default CSS for it?

done, #8151