remove unused lib #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgonggrijp
reviewed
Apr 8, 2020
There was a problem hiding this comment.
Thank you for pointing out the unused imports, @even-even. I found one mistake and one oversight, but I already fixed them for you in an upstream commit.
| import re | ||
| import argparse | ||
| from functools import partial | ||
| import logging | ||
| import json | ||
| import sys | ||
| import pip | ||
| import subprocess |
There was a problem hiding this comment.
subprocess is actually used. But you were probably testing on Python 3, which allows you to remove it here because subprocess is also imported in the PY3 branch on line 16. I removed the latter instead.
| from packaging import version | ||
|
|
||
| PY3 = sys.version_info.major == 3 | ||
| if PY3: # Python3 Imports | ||
| import urllib.request as urllib_request |
There was a problem hiding this comment.
You were right to remove this, but you forgot to remove it in the Python 2 branch on line 29 as well. I already fixed that for you.
|
See f107912 for the fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lib unused in code