Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused lib #81

Merged
merged 1 commit into from
Apr 8, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 0 additions & 3 deletions pip_review/__main__.py
Original file line number Diff line number Diff line change
@@ -1,18 +1,15 @@
from __future__ import absolute_import
import os
import re
import argparse
from functools import partial
import logging
import json
import sys
import pip
import subprocess
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

subprocess is actually used. But you were probably testing on Python 3, which allows you to remove it here because subprocess is also imported in the PY3 branch on line 16. I removed the latter instead.

from packaging import version

PY3 = sys.version_info.major == 3
if PY3: # Python3 Imports
import urllib.request as urllib_request
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You were right to remove this, but you forgot to remove it in the Python 2 branch on line 29 as well. I already fixed that for you.

import subprocess

def check_output(*args, **kwargs):
Expand Down
1 change: 0 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
"""
pip-review lets you smoothly manage all available PyPI updates.
"""
import sys
from setuptools import setup


Expand Down