Sb10ad fix synthesis.pyf #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix is a bit of a guess, but after this the signature matches that expected by synthesis.py's use of _wrapper.sb10ad, and a simple test case works.
Simple-as-possible test, with some reference values from Octave.
This was referenced Jun 27, 2016
cwrowley
pushed a commit
to cwrowley/Slycot
that referenced
this pull request
Dec 26, 2016
Use conda for building (and consequently drop Py 2.6, 3.2, add 3.4, 3.5).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sb10ad entry in synthesis.pyf did not infer ldac, ldab, ldac, ldad values from ac, bc, cc, dc, but instead looked like
The last line should be ldac, not ldak; the same bug is present for ldbc, etc.
I'm don't know enough about f2py to know if it should have raised a warning or error in this case.
Added a simple test for this case.