Fix a bug that caused batch requests with a body to fail.

Fixes #55.
jgorset · Aug 6, 2012 · a5c58ba · a5c58ba
1 parent d0cf02b
commit a5c58ba
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/facepy/graph_api.py b/facepy/graph_api.py
@@ -125,6 +125,11 @@ def batch(self, requests):
 
         Yields a list of responses and/or exceptions.
         """
+
+        for request in requests:
+            if 'body' in request:
+                request['body'] = urlencode(request['body'])
+
         responses = self.post(
             batch = json.dumps(requests)
         )

diff --git a/tests/test_graph_api.py b/tests/test_graph_api.py
@@ -324,7 +324,8 @@ def test_batch():
 
     requests = [
         { 'method': 'GET', 'relative_url': 'me/friends' },
-        { 'method': 'GET', 'relative_url': 'me/photos' }
+        { 'method': 'GET', 'relative_url': 'me/photos' },
+        { 'method': 'POST', 'relative_url': 'me/feed', 'body': { 'message': 'Hi me.' } }
     ]
 
     batch = graph.batch(
@@ -337,7 +338,11 @@ def test_batch():
     mock_request.assert_called_with('POST', 'https://graph.facebook.com/',
         files = {},
         data = {
-            'batch': json.dumps(requests),
+            'batch': json.dumps([
+                { 'method': 'GET', 'relative_url': 'me/friends' },
+                { 'method': 'GET', 'relative_url': 'me/photos' },
+                { 'method': 'POST', 'relative_url': 'me/feed', 'body': 'message=Hi+me.' }
+            ]),
             'access_token': '<access token>'
         }
     )