Add Get Window Position and Set Window Position commands

[andreastt]

Commands are added to the WebDriver specification in
w3c/webdriver#307.

---

This change is

[andreastt]

@jgraham r?

[jgraham]

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 3 unresolved discussions.

---

src/command.rs, line 573 [r1] (raw file):

impl Parameters for WindowPositionParameters {
    fn from_json(body: &Json) -> WebDriverResult<WindowPositionParameters> {
        let data = try_opt!(body.as_object(), ErrorStatus::UnknownError, "Message body was not an object");

I think these should be broken over multiple lines.

---

src/response.rs, line 22 [r1] (raw file):

impl WebDriverResponse {
    pub fn to_json_string(self) -> String {
        let s = match self {

Please revert. The () are unneeded.

---

src/response.rs, line 87 [r1] (raw file):

impl WindowPositionResponse {
    pub fn new(x: u64, y: u64) -> WindowPositionResponse {
        WindowPositionResponse { x: x, y: y }

Use multiple lines.

---

Comments from Reviewable

[andreastt]

Review status: 1 of 3 files reviewed at latest revision, 3 unresolved discussions.

---

src/response.rs, line 87 [r1] (raw file):

Previously, jgraham wrote…

Use multiple lines.

I’ve put this on multiple lines. However, I checked that rustfmt uses this style, which is why I chose it.

---

Comments from Reviewable

[andreastt]

Review status: 1 of 3 files reviewed at latest revision, 3 unresolved discussions.

---

src/command.rs, line 573 [r1] (raw file):

Previously, jgraham wrote…

I think these should be broken over multiple lines.

Done.

---

src/response.rs, line 22 [r1] (raw file):

Previously, jgraham wrote…

Please revert. The () are unneeded.

Done.

---

Comments from Reviewable

[andreastt]

Review status: 1 of 3 files reviewed at latest revision, 3 unresolved discussions.

---

src/response.rs, line 87 [r1] (raw file):

Previously, andreastt (Andreas Tolfsen) wrote…

I’ve put this on multiple lines. However, I checked that rustfmt uses this style, which is why I chose it.

Done.

---

Comments from Reviewable

[andreastt]

@jgraham Mind taking another look?

[AutomatedTester]

@jgraham ping

[jgraham]

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable