Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix saving and exporting in Pale Moon #232

Closed
wants to merge 2 commits into from
Closed

Conversation

adeshkp
Copy link

@adeshkp adeshkp commented Mar 9, 2018

Saving and exporting does not work in Pale Moon browser due to mxXmlRequest.simulate not working. Apply the same workaround as already done for Safari.

See: https://forum.palemoon.org/viewtopic.php?p=135614#p135614

@davidjgraph
Copy link
Collaborator

Thanks for the submission. The mxclient change would actually go in the core project, in Bitbucket, that's the built mxclient.js.

The reason for determining browsers by user agents is legacy. We've set a bad example here by doing it, so we shouldnt really complain when PRs do it. However, I'd love to see this done as a capability check, instead. Maybe it can't actually be done, but I'd prefer it to be tried before we resort to this method.

@alderg
Copy link
Contributor

alderg commented Jun 12, 2018

Thanks, this will be fixed in the next release.

@alderg alderg closed this Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants