New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrectly checking sx128x command status #843

Merged

jgromes merged 1 commit into jgromes:master from chemary:fix/sx128x-spi-parse-status

Oct 11, 2023

Contributor

chemary commented Oct 10, 2023 •

edited

Loading

In SX128x::SPIparseStatus the bit mask to check the command status is incorrect, it's checking bits 3:1 when the documentation says that are 4:2

You can replace the constants and clearly see that they don't make sense

if((status & 0b00001110) == RADIOLIB_SX128X_STATUS_CMD_TIMEOUT)
if((status & 0b00001110) == RADIOLIB_SX128X_STATUS_CMD_ERROR)
if((status & 0b00001110) == RADIOLIB_SX128X_STATUS_CMD_FAILED)
// replacing the constant becomes
if((status & 0b00001110) == 0b00001100)
if((status & 0b00001110) == 0b00010000)
if((status & 0b00001110) == 0b00010100)


          Incorrectly checking sx1280 command status

9a96d6c

jgromes merged commit ddcce42 into jgromes:master

29 checks passed

Owner

jgromes commented Oct 11, 2023

Seems like a copy-paste error from the SX126x driver. Merged, thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet