Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the PHPClasses 2020 entry. #47

Closed
wants to merge 2 commits into from

Conversation

manuellemos
Copy link

No description provided.

@nfabre
Copy link

nfabre commented Sep 23, 2020

Why is this PR not yet merged, since elephants can be found at this address?
https://www.phpclasses.org/shop/category/ms/

@jgrossi
Copy link
Owner

jgrossi commented Sep 23, 2020

folks what's the different between this elephpant and the 2018 version? it's the same, same color, but a different "production" correct? for example: we have the blue elephpant, we have different elephpants (productions) but the model is the same

any comments please?

@doppynl
Copy link
Contributor

doppynl commented Sep 23, 2020

Looks the same to me. Just a new production run.
If you were to add each production run, then the opengoodies blue&pink would have to be on it more than twice as well. Don't think we want that.

@nfabre
Copy link

nfabre commented Sep 23, 2020

I understand your point of view and I'm in line with it, but to be consistent we have to rename the elephpant "PHPClasses 2018" to PHPClasses.

@jgrossi
Copy link
Owner

jgrossi commented Sep 23, 2020

thanks for the feedback folks. gonna rename the PHPClasses 2018 to just PHPClasses if we have another color later of something we change the name and then create a new one. thanks all

@jgrossi
Copy link
Owner

jgrossi commented Sep 23, 2020

changed the name and photo for the "phpclasses" one in here #55

once that PR is merged I close this one

@IgorDuarte17
Copy link
Collaborator

I agree with you, it is a new production of the same model, it seems to me that it has had some small improvements, but it remains the same.
The best strategy is to update the existing data and close this PR.

@pgrimaud pgrimaud mentioned this pull request Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants