Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partials naming convention - SASS Partial's name should start with an underscore "_" #2401

Closed
vivekraj-kr opened this issue Mar 11, 2019 · 3 comments

Comments

@vivekraj-kr
Copy link

vivekraj-kr commented Mar 11, 2019

SASS Partial's name should start with an underscore. The underscore lets Sass know that the file is only a partial file and that it should not be generated into a CSS file.

@vivekraj-kr vivekraj-kr changed the title Partials naming convention - SASS Partials name should start with underscore "_" Partials naming convention - SASS Partial's name should start with an underscore "_" Mar 11, 2019
@jgthms
Copy link
Owner

jgthms commented Mar 11, 2019

Why not, although it might break some setups. The partials are not generated in any case, so it’s not really an issue. The scripts only generate one CSS file.

@jgthms jgthms closed this as completed Mar 11, 2019
@starwed
Copy link

starwed commented Oct 13, 2019

@jgthms Hello, I'm a bit confused about your stance on this. "Why not" sounds like you're agreeing with the issue opener, but you also closed it.

In general the issue is that this prevents Bulma from being built as part of a general SASS build, e.g. this issue with Zola

@Karkunow
Copy link

@jgthms @vivekraj-kr
I have a problem with the Bulma build in Clojurescript for the exact same reason!
Please fix this. It is a very annoying problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants