Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support icons on input type="submit" with class .button #2407

Closed
rodrigoaguilera opened this issue Mar 13, 2019 · 11 comments
Closed

Support icons on input type="submit" with class .button #2407

rodrigoaguilera opened this issue Mar 13, 2019 · 11 comments

Comments

@rodrigoaguilera
Copy link
Contributor

This is about Bulma.

Overview of the problem

This is about the Bulma CSS framework
I'm using Bulma version [0.7.4]
I am sure this issue is not a duplicate?

Description

Be able to have an icon on submit inputs that are styled as buttons.

Steps to Reproduce

Consider the following markup

<div class="field">
  <p class="control has-icons-left">
    <input class="button" type="submit">
     <span class="icon is-small is-left">
      <i class="fas fa-lock"></i>
    </span>
    </p></div>

It produces a button with an icon that is almost right. I think it only needs some padding.

Expected behavior

A good looking submit button without messing with my CMS form markup.

Actual behavior

No icon on on submit inputs

@jgthms
Copy link
Owner

jgthms commented May 17, 2019

Why not use <button>?

@rodrigoaguilera
Copy link
Contributor Author

<input> is the default of Drupal for submit buttons and sadly is not that easy to change (although possible). I just thought this could be a nice feature that as a side effect simplify my code a bit.

@jgthms
Copy link
Owner

jgthms commented May 17, 2019

I see. I'll have a look.

@stale
Copy link

stale bot commented Nov 13, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 13, 2019
@rodrigoaguilera
Copy link
Contributor Author

I really would like if you can give this a chance

@stale stale bot removed the stale label Nov 13, 2019
@jondoe1337
Copy link

Is there any workaround for this?

@stale
Copy link

stale bot commented Sep 19, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 19, 2020
@rodrigoaguilera
Copy link
Contributor Author

I just rebased the PR in the hope that this can get a bit of attention

@stale stale bot removed the stale label Sep 20, 2020
@timothykemp
Copy link

I would also love to see this functionality added!

@stale
Copy link

stale bot commented Jun 3, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 3, 2021
@rodrigoaguilera
Copy link
Contributor Author

I would like to get some answer about if this can be considered for inclusion.

@stale stale bot closed this as completed Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants