Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility issue with bulma reset #3588

Open
Eduruiz opened this issue Nov 8, 2022 · 4 comments · May be fixed by #3591
Open

Accessibility issue with bulma reset #3588

Eduruiz opened this issue Nov 8, 2022 · 4 comments · May be fixed by #3591

Comments

@Eduruiz
Copy link

Eduruiz commented Nov 8, 2022

This is about Bulma.

Overview of the problem

This is about the Bulma CSS framework

Description

Bulma reset file has a font-size: 16px; declaration in the html, this breaks the accessibility of websites for users who have vision impairment and scale up the font size of the browser.

Steps to Reproduce

  1. set your font with relative units
  2. update your browser font-size preferences
  3. check your website

Expected behavior

The font size of the entire application (and all other relative set sizes) should scale up with the chosen size

Actual behaviour

Nothing changes since the html font-size are set in pixels

@jgthms
Copy link
Owner

jgthms commented Nov 8, 2022

I agree that the html font-size should be set to 1em, which should resolve this issue.

@Eduruiz
Copy link
Author

Eduruiz commented Nov 9, 2022

I was going to change it and open the MR but I just found the value in pixels on the bulma.css and bulma-rtl.css not in the sass/base/minireset.scss where I think it should be. I'm I missing something? It's just a build missing to update the css files?

update: I run a build-sass and the 16px keep being generated on the CSS file.

@jgthms
Copy link
Owner

jgthms commented Nov 9, 2022

It’s in generic.sass

Eduruiz pushed a commit to Eduruiz/bulma-no-reset that referenced this issue Nov 10, 2022
@Eduruiz
Copy link
Author

Eduruiz commented Nov 10, 2022

oh! got it! thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants