Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for combined button modifiers #61

Closed
ezimir opened this issue Feb 8, 2016 · 5 comments
Closed

Support for combined button modifiers #61

ezimir opened this issue Feb 8, 2016 · 5 comments
Labels

Comments

@ezimir
Copy link

ezimir commented Feb 8, 2016

For example:

.is-primary.is-outlined.is-loading

produces

button
(you can see a faint loading indicator over the text)

@jgthms
Copy link
Owner

jgthms commented Feb 13, 2016

Mmmh, must be an issue with order of the classes, because is-primary is-loading already works.

@jgthms jgthms added the bulma label Feb 13, 2016
@ezimir
Copy link
Author

ezimir commented Feb 13, 2016

More precisely, is-outlined breaks is-loading when the button has a color class, like is-primary.

These combinations are fine:
button is-primary is-loading
button is-primary is-outlined
button is-loading is-outlined (same as button is-loading)

This is not:
button is-primary is-outlined is-loading

@jgthms jgthms closed this as completed May 29, 2016
@ezimir
Copy link
Author

ezimir commented May 30, 2016

@jgthms Why close this?

is-outlined still breaks is-primary is-loading combination. And is-inverted too.

@jgthms
Copy link
Owner

jgthms commented May 30, 2016

Ah yes, you're right.

@jgthms jgthms reopened this May 30, 2016
@jgthms
Copy link
Owner

jgthms commented Mar 17, 2017

This works now:
image

@jgthms jgthms closed this as completed Mar 17, 2017
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants