Fixed responsive breakpoints #2039
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation suggests breakpoints for desktop, widescreen and fullhd are from: 1024px, 1216px and 1408px respectively. Comments in sass/utilities/initial-variables.sass corroborate this (container base width + 4 rem i.e. 64px). Also, real life agrees too (e.g. desktop width traditionally starts at 1024px). Prior to this commit; desktop, widescreen and fullhd breakpoints were wrongly: 1088px, 1280px and 1472px (because $gap was multiplied twice - a hang over from when $gap was 32px rather than 64px?).
Seems a cleaner way to fix the breakpoints (given sass/elements/container.sass would have been negatively impacted by the earlier commit). Having done a code search for $gap it's not clear what effect changing this value back to 32px (from 64px) has on the rest of bulma (at first glance: nothing).
|
Im actually having the same issue here, these commits hasnt been merged into the master branch has it? |
|
Hasn't been merged yet (hoping it will at some point). See issue here: #1864 |
|
Other solution is to set $desktop variable: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the desktop, widescreen and fullhd breakpoints seem wrong: 1088px, 1280px and 1472px (issue appears to be caused by a commit that changed $gap from 32px to 64px).
Documentation suggests breakpoints for desktop, widescreen and fullhd should be from: 1024px, 1216px and 1408px respectively. Comments in sass/utilities/initial-variables.sass corroborate this (container base width + 4 rem i.e. 64px). Real life agrees too (e.g. desktop width traditionally starts at 1024px).
This PR brings the breakpoints back in line with the documentation by reverting $gap to 32px (instead of 64px).
This is a bugfix.
Proposed solution
Revert to value of 32px for $gap
Tradeoffs
None (afaik). A code search across the bulma source code for $gap seems to suggest no negative impact.
Testing Done
Used forked repo with the change applied and breakpoints appear to work as documentation suggests.