Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation additions #2284

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Documentation additions #2284

wants to merge 3 commits into from

Conversation

tomhrtly
Copy link
Contributor

This is a documentation fix.

This PR adds information regarding the table-container class, the different sizes for the menu component and adds the is- prefix for the responsive helpers.

Copy link
Owner

@jgthms jgthms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Just a few duplicate things to fix.

@@ -314,6 +314,98 @@
</table>
{% endcapture %}

{% capture table_responsive_example %}
<div class="table-container">
<table class="table">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just use {{ table_example }} here to avoid repeating.

<li><code>inline</code></li>
<li><code>inline-block</code></li>
<li><code>inline-flex</code></li>
<li><code>is-block</code></li>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has already been fixed I believe.

@@ -10,6 +10,17 @@
- columns-options
---

{% capture columns_vcentered %}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This already exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants