Add support for tables without table tags #2301
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an improvement.
It adds the ability to get table styling without using table tags (
table
,tr
,td
, etc.)With this PR you can use whatever HTML tags you want and still have the content displayed as a table. I used it to put an anchor tag (
a
) where a table row tag (tr
) would ordinarily be, this making the entire row clickable.Proposed solution
Everywhere we have styling for table tags, I have added a class selector that will apply the same styling. I have also added a
display
property so the class will be rendered just like the corresponding tag.Tradeoffs
Downsides:
display
property is redundant for the tags and may causes problems if someone had done the extremely weird thing of overriding them. That could be limited to the CSS selectors.Upsides
Testing Done
This works in the current version of the Neverbust transaction list https://www.neverbust.com/transactions.