Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tables without table tags #2301

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for tables without table tags #2301

wants to merge 1 commit into from

Conversation

ExMember
Copy link

@ExMember ExMember commented Jan 2, 2019

This is an improvement.

It adds the ability to get table styling without using table tags (table, tr, td, etc.)

With this PR you can use whatever HTML tags you want and still have the content displayed as a table. I used it to put an anchor tag (a) where a table row tag (tr) would ordinarily be, this making the entire row clickable.

Proposed solution

Everywhere we have styling for table tags, I have added a class selector that will apply the same styling. I have also added a display property so the class will be rendered just like the corresponding tag.

Tradeoffs

Downsides:

  • More selectors in the SASS.
  • There are now two ways to create a table.
  • The display property is redundant for the tags and may causes problems if someone had done the extremely weird thing of overriding them. That could be limited to the CSS selectors.

Upsides

  • New table styling more closely matching the style guide directive to use only CSS classes.

Testing Done

This works in the current version of the Neverbust transaction list https://www.neverbust.com/transactions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant