Refactor columns.sass to use map values #2559
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an improvement.
This is an improvement in readability to the
columns.sass
.There are too many blocks of code repeating
.is-one-third-*
over and over.Proposed solution
We are using a name-value map to reference very well defined variable-name values and looping through them rather than specifying each one directly.
Note: Decreased the file size by more than half (~300 lines)
Tradeoffs
This solution may increase build time - but not substantially.
Testing Done
These changes do not affect the output CSS file
I did look at the documentation site to ensure all changes are working correctly
Changelog updated?
Yes.