Columns too wide on mobile #660
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses jgthms#449 overflowing `.columns` on mobile.
jgthms
reviewed
Apr 15, 2017
| @@ -242,6 +243,9 @@ | |||
| &.is-vcentered | |||
| align-items: center | |||
| // Responsiveness | |||
| +mobile | |||
| margin-left: 0 | |||
| margin-right: 0 | |||
There was a problem hiding this comment.
Bulma is mobile-first. So this should be undone on tablet.
| @@ -41,6 +41,7 @@ | |||
| .columns.is-mobile > &.is-offset-#{$i} | |||
| margin-left: ($i / 12) * 100% | |||
| +mobile | |||
| padding: 0.75rem 0 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed solution
When using
.columnson a mobile device, the margin-right: -0.75rem causes the body to overflow.This makes it possible for the user to scroll and see whitespace.
By changing the horizontal padding and margin on mobile, this issue is resolved.
Fixes: #449
Tradeoffs
People relying on the horizontal padding for mobile will lose this.
Testing Done
Works on Chrome (OS X)