Fixes #460 - modal component horizontally not centered in IE #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed solution
In modal component, modal horizontally not centered in IE 11 and IE lower version.
modal-contentis child of absolute position div, there is a bug formargin: 0 auto;in IE, when it is child of parent which have absolute position.margin: 0;will make modal horizontally centered in IE and it will not break anything.Tradeoffs
Removing auto in margin will make modal horizontally centered in IE and it will not break anything.
Testing Done
Browsing local version of docs/_site.