Add kcov to images

[RX14]

For coverage support on crystal travis

[jhass]

Did you look if there's a PPA or something available? Compiling makes updating either kcov or the base image a bit brittle :/

[RX14]

@jhass why is compiling more brittle than downloading?

And no, there look to be no ppas with the latest release that I saw. Maybe I'm blind.

[jhass]

It's more brittle because with a package the maintainer would keep up with any necessary changes to building the project, such as new dependencies, changed invocation of the build commands or patches necessary to support updated dependencies (such as GCC7 for example). Compiling on our own requires doing all that on our own too.

[jhass]

Couldn't find any repo either :/ So I'll accept this if it'll really be used by Crystal.

[ivy]

Since we're only checking out a tag and don't need the repository's entire history, we could instead download and extract a repository tarball:

mkdir /tmp/kcov && cd /tmp/kcov && \
  curl -fSL https://github.com/SimonKagstrom/kcov/archive/v33.tar.gz | \
  tar -xzf - --strip-components=1

[RX14]

We could, but we're deleting the directory anyway so it doesn't affect image size. I'd much prefer using --depth=1 to the extra work of using a tarball.

[ivy]

That works too 😁

…

On Wed, Jul 12, 2017 at 04:32 Chris Hobbs ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In i386/Dockerfile <#2 (comment)> : > apt-get update && \ -apt-get install -y crystal +apt-get install -y crystal && \ +\ +git clone https://github.com/SimonKagstrom/kcov /tmp/kcov && \ We could, but we're deleting the directory anyway so it doesn't affect image size. I'd much prefer using --depth=1 to the extra work of using a tarball. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADgWUCaAdFdYCUNcP4KvUzqtMpUBMKWfks5sNJKhgaJpZM4N105Q> .