FIXBUG: Invitation raise an exception if contact or other invitation …

…exists

* Created custom exceptions.
* Refactored partials for flash messsages.

app/controllers/invitations_controller.rb

@@ -1,4 +1,11 @@
 class InvitationsController < ApplicationController
+  rescue_from Exceptions::Invitations::ContactExists do
+    redirect_to(contacts_path, :alert => I18n.t("views.invitations.flash.contact_exists"))
+  end
+  rescue_from Exceptions::Invitations::InvitationExists do
+    redirect_to(contacts_path, :alert => I18n.t("views.invitations.flash.invitation_exists"))
+  end
+
   # GET /invitations
   def index
     @invitations = current_user.received_invitations.order("created_at DESC").paginate(:page => params[:page])

app/models/invitation.rb

@@ -1,4 +1,6 @@
 class Invitation < ActiveRecord::Base
+  before_create :is_necessary?
+
   belongs_to :sender, :class_name => 'User'
   belongs_to :receiver, :class_name => 'User'
 
@@ -12,4 +14,17 @@ def accept
     Contact.create(:friend => sender,
                    :user => receiver)
   end
+
+  protected
+
+  def is_necessary?
+    if Contact.reverse_proxy(User.find(self.receiver_id))
+      raise Exceptions::Invitations::ContactExists
+    end
+
+    if Invitation.where(:sender_id => self.sender_id, :receiver_id => self.receiver_id).first ||
+       Invitation.where(:sender_id => self.receiver_id, :receiver_id => self.sender_id).first
+      raise Exceptions::Invitations::InvitationExists
+    end
+  end
 end

app/views/layouts/_flash_message.html.erb

@@ -0,0 +1,8 @@
+<% if flash[key] -%>
+  <div class="grid_6 prefix_3 suffix_3">
+    <div class="<%= key.to_s %>">
+      <%= flash[key] %>
+    </div>
+  </div>
+  <%= render 'shared/clear' %>
+<% end -%>

app/views/layouts/application.html.erb

@@ -18,8 +18,8 @@
 
     <div class="layout">
       <div class="container_12">
-        <%= render 'layouts/alert' %>
-        <%= render 'layouts/notice' %>
+        <%= render 'layouts/flash_message', :key => :alert %>
+        <%= render 'layouts/flash_message', :key => :notice %>
         <%= yield :subnavigation %>
         <%= yield %>
       </div>

config/locales/views/invitations/en.yml

@@ -14,3 +14,5 @@ en:
       flash:
         sended: "The invitation was successfully sended"
         error: "The invitation couldn't send"
+        contact_exists: "The invitation couldn't send: the contact already exists"
+        invitation_exists: "The invitation couldn't send: there is a pending invitation"

config/locales/views/invitations/es.yml

@@ -14,3 +14,5 @@ es:
       flash:
         sended: "La invitación se ha enviado con éxito"
         error: "No se pudo enviar la invitación"
+        contact_exists: "No se pudo enviar la invitación: el contacto ya existe"
+        invitation_exists: "No se pudo enviar la invitación: ya hay una invitación pendiente"

lib/debt_pursuit/version.rb

@@ -2,7 +2,7 @@ module DebtPursuit
   module Version
     MAYOR = "0"
     MINOR = "9"
-    PATCH = "0"
+    PATCH = "1"
 
     NUMBER = [MAYOR, MINOR, PATCH].join(".")
 

lib/exceptions/invitations.rb

@@ -0,0 +1,6 @@
+module Exceptions
+  module Invitations
+    class ContactExists < StandardError; end
+    class InvitationExists < StandardError; end
+  end
+end

public/stylesheets/layout.css

@@ -58,8 +58,6 @@ h4 { font-size: 20px; }
 .alert,
 .notice {
   text-align: center;
-  width: 95%;
-  max-width: 310px !important;
   margin-bottom: 10px;
   padding: 5px;
 }

test/functional/invitations_controller_test.rb

@@ -31,4 +31,23 @@ class InvitationsControllerTest < ActionController::TestCase
 
     assert_redirected_to invitations_path
   end
+
+  test "should rescue from existence of contact" do
+    @invitation.accept
+    post :create, :invitation => Factory.build(:invitation,
+                                               :sender => @invitation.sender,
+                                               :receiver => @invitation.receiver).attributes
+
+    assert_redirected_to contacts_path
+    assert flash[:alert]
+  end
+
+  test "should rescue from existence of invitation" do
+    post :create, :invitation => Factory.build(:invitation,
+                                               :sender => @invitation.sender,
+                                               :receiver => @invitation.receiver).attributes
+
+    assert_redirected_to contacts_path
+    assert flash[:alert]
+  end
 end

test/unit/invitation_test.rb

@@ -20,4 +20,38 @@ class InvitationTest < ActiveSupport::TestCase
     assert_equal sender_contacts + 1, sender.contacts.count
     assert_equal receiver_contacts + 1, receiver.contacts.count
   end
+
+  test "should not save if the users are friends" do
+    sender = Factory.create(:user)
+    receiver = Factory.create(:user)
+    invitation = Factory.create(:invitation,
+                                :sender => sender,
+                                :receiver => receiver)
+    invitation.accept
+    invitation.destroy
+
+    invitation = Factory.build(:invitation,
+                               :sender => sender,
+                               :receiver => receiver)
+
+    assert_raise(Exceptions::Invitations::ContactExists) { invitation.save }
+  end
+
+  test "should not save if exists other invitation" do
+    sender = Factory.create(:user)
+    receiver = Factory.create(:user)
+    invitation = Factory.create(:invitation,
+                                :sender => sender,
+                                :receiver => receiver)
+
+    invitation = Factory.build(:invitation,
+                               :sender => sender,
+                               :receiver => receiver)
+    assert_raise(Exceptions::Invitations::InvitationExists) { invitation.save }
+
+    invitation = Factory.build(:invitation,
+                               :sender => receiver,
+                               :receiver => sender)
+    assert_raise(Exceptions::Invitations::InvitationExists) { invitation.save }
+  end
 end