Skip to content
This repository has been archived by the owner on Apr 19, 2024. It is now read-only.

[bug] Typescript 5.0 issues (deno 1.32.x) #27

Closed
jhechtf opened this issue Apr 17, 2023 · 4 comments
Closed

[bug] Typescript 5.0 issues (deno 1.32.x) #27

jhechtf opened this issue Apr 17, 2023 · 4 comments
Labels
bug Something isn't working investigation Used to determine next-steps

Comments

@jhechtf
Copy link
Owner

jhechtf commented Apr 17, 2023

Description

If a user upgrades to Deno 1.32.x their Typescript version will be bumped to 5.x. This introduces some weirdness with decorators, and as such causes this project to fail.

There is already an issue on Tsyringe, and depending on how well I can get into the code to determine what happens it might be something I can contribute back to Tsyringe, but it may be out of my depth for a new project. In which case, any version of Version-Bump that could support 5.x would likely need to move off of Tsyringe.

Inversify was tested with a very simple example and seemed to hold up for our use case, but further exploration would be needed.

Exit Criteria

  1. Determine if it is do-able to add in the necessary code to TSyringe that makes it 5.x compatible.
  2. Otherwise, build a small CLI similar to our use case but utilizing Inversify. It should be backwards compatible with previous versions of Deno, so some heavy testing is going to end up being required.
@jhechtf
Copy link
Owner Author

jhechtf commented Apr 17, 2023

There appears to have been a commit recently, that is unpublished in TSyringe that should resolve the issue

microsoft/tsyringe#226

Once that is published we will work to verify functionality in Deno v 1.32.x (TS >= 5.x)

@jhechtf jhechtf added bug Something isn't working investigation Used to determine next-steps labels Apr 18, 2023
@jhechtf
Copy link
Owner Author

jhechtf commented May 31, 2023

We are still waiting for the TSyringe team to release the change that works for TS 5; until then we are stuck without the ability to support the latest version(s) of Deno.

@jhechtf
Copy link
Owner Author

jhechtf commented Jun 20, 2023

As noted in #37, TSyringe has released the update to allow for the code to run in TS5 environments. However, I will still be pushing ahead to see how the codebase functions. TSyringe had some minor pain points that Inversify is possibly addressing. Whether it gets merged or not, I will complete the move over to Inversify and do some QoL testing before going forward as this would be a breaking change.

@jhechtf
Copy link
Owner Author

jhechtf commented Jun 26, 2023

An update has been released for TSyringe in the current branch.

I am testing version-bump with inversify as a v2 release. So far all the tests are passing, but I still want to see if this adds anything that the current patched version of TSyringe has.

@jhechtf jhechtf closed this as completed Jun 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working investigation Used to determine next-steps
Projects
None yet
Development

No branches or pull requests

1 participant