Fix taxonomy term creation #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`parent` may be empty if multiple taxonomies are created in a single `Given` block. Additionally `id` is not the right base field for the query but it should be `name`. Finally the entityQuery does not return loaded entities but returns IDs so calling `->id()` on it will break as well.
Closed
Kingdutch
added a commit
to goalgorilla/open_social_dev
that referenced
this pull request
Dec 13, 2022
drupal-driver 2.2.1 introduced Drupal 10 compatibility but also broke term creation. A fix is proposed in jhedstrom/DrupalDriver#260 However, 2.2.1 of the extension also set a conflict with Drupal 8 based code which means 2.2.1 can't work with Open Social 10. Since we need our developer tools to be compatible with both our major versions to test our upgrade path we downgrade our drupal-driver version. Once we release Open Social 12 and stop testing 10 -> 11 but test 11 -> 12 instead we can drop Drupal 8 support completely and remove our drupal-driver constraint. Given that the contents was broken in 2.2.1 we also can't apply our patch from 260 to version 2.2.0 which is what breaks our install in Open Social 10 in the first place. This commit assumes we don't need Drupal 10 support before Open Social 12, otherwise we'll need to find a different solution.
|
Thank you, this is working for me. |
|
Thank you! |
jhedstrom
added a commit
that referenced
this pull request
Jan 6, 2023
Fix taxonomy term creation Signed-off-by: Jonathan Hedstrom <jhedstrom@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parentmay be empty if multiple taxonomies are created in a singleGivenblock.Additionally
idis not the right base field for the query but it should bename.Finally the entityQuery does not return loaded entities but returns IDs so calling
->id()on it will break as well.Fixes #259