Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfigContext config set cannot be run multiple times in one scenario #498

Closed
upchuk opened this issue Aug 14, 2018 · 1 comment
Closed

Comments

@upchuk
Copy link
Contributor

upchuk commented Aug 14, 2018

The ConfigContext::setConfig() keeps a backup of the config that we set. However, if we need to set it multiple times in the same scenario the backup is overridden by the last time it runs. The fix is pretty simple: check if the backup has already been made already before setting it.

upchuk added a commit to openeuropa/drupalextension that referenced this issue Aug 14, 2018
upchuk added a commit to openeuropa/drupalextension that referenced this issue Aug 14, 2018
@pfrenssen
Copy link
Collaborator

This looks good to me. Thanks for the contribution!

Looking at this code I am thinking that the setConfig() method should be made protected. The public version of this is called setBasicConfig() and has a step definition associated with it. I will make a followup for this.

jhedstrom added a commit that referenced this issue Oct 17, 2018
GH-498 - Fixing ConfigContext backup strategy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants