Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ConfigContext::setConfig() protected #500

Open
pfrenssen opened this issue Aug 14, 2018 · 0 comments
Open

Make ConfigContext::setConfig() protected #500

pfrenssen opened this issue Aug 14, 2018 · 0 comments
Labels
enhancement good first issue

Comments

@pfrenssen
Copy link
Collaborator

As commented in #498 we should make the ConfigContext::setConfig() method protected. This is the helper method that actually sets the configuration. The class already has a public method for this purpose: ::setBasicConfig() which has a step definition associated with it.

We don't need 2 public methods that do exactly the same thing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pfrenssen