Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logout performance #427

Merged
merged 4 commits into from
Dec 6, 2017
Merged

Logout performance #427

merged 4 commits into from
Dec 6, 2017

Conversation

jhedstrom
Copy link
Owner

This addresses #62 and includes the logout hardening commit from #393.

Signed-off-by: Jonathan Hedstrom <jhedstrom@gmail.com>
@jhedstrom jhedstrom added this to the 4.0 release milestone Dec 1, 2017
@jhedstrom
Copy link
Owner Author

To take full advantage of this, the logout method in RawDrupalContext should probably take a $fast parameter (and the method here should be added to a separate interface). Then steps that don't require an actual logout (eg, assertAnonymousUser, etc) can pass in TRUE to utilize the fast logout. This can also be used during user cleanup.

@jhedstrom jhedstrom merged commit 2eb9232 into master Dec 6, 2017
@jhedstrom jhedstrom deleted the 62-logout-performance branch December 6, 2017 21:29
@jhedstrom
Copy link
Owner Author

I've decided to merge this and tag an alpha release of 4.0. We can do follow-ups if folks find issues.

@m4olivei
Copy link
Contributor

I think I found an issue with this when using the Selenium Mink Driver, see #446, and corresponding PR #447

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants