#446 Check for session first before logging out in fastLogout method of DrupalAuthenticationManager #447
Conversation
…t method of DrupalAuthenticationManager
|
This patch works for me. I think it's a Selenium specific issue, where the Selenium Mink Driver is assuming that the session is already started when you call |
|
Incidentally, I see there is some awesome test coverage in this package. I wonder if it would be possible to have some test cases with Mink Selenium2 Driver and a browser like Chrome? |
That would be great! Happy to review PRs that update |
| $session = $this->getSession(); | ||
| if ($session->isStarted()) { | ||
| $session->reset(); | ||
| $this->userManager->setCurrentUser(false); |
There was a problem hiding this comment.
I wonder if we should unset the user outside the conditional?
There was a problem hiding this comment.
That makes sense, will update.
I took an honest look at it (being new to Travis), and it seems like it would be tricky to get all the dependencies right to be able to run chrome in a window manager and hook selenium up to it. I've seen it done in CircleCI before. Although it would be nice, I'm going to slowly climb out of this rabbit hole for now 😄. |
|
Thanks! |
|
@m4olivei I found this Travis setup for the mink selenium driver, it might help you out if you get the chance :) |
Attempt at resolving #446.