Skip to content

Commit

Permalink
Avoid apollo backend message sent to Debugger proxy, related to #311
Browse files Browse the repository at this point in the history
  • Loading branch information
@jhen0409
jhen0409 committed Feb 1, 2019
1 parent a58d3eb commit bf1e92c
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions app/middlewares/debuggerAPI.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ const workerOnMessage = message => {
},
'*'
);
return false;

This comment has been minimized.

Sign in to view

Copy link
@Gongreg

Gongreg Feb 1, 2019

Collaborator

@jhen0409, can you explain me what was the issue here?

This comment has been minimized.

Sign in to view

Copy link
@Gongreg

Gongreg Feb 1, 2019

Collaborator

Also quick unrelated question, but would it be okay if we always displayed apollo tab?

I am thinking of proper way to handle apollo.
Currently it wait 10 seconds for apollo client and then stops checking.

It can be hard to explain for users why they don't see apollo tab.

This comment has been minimized.

Sign in to view

Copy link
@jhen0409

jhen0409 Feb 1, 2019

Author Owner

@Gongreg it avoid the data send to the debugger proxy of React Native packager, it may cause unexpected errors, it used for react-native bridge:

socket.send(JSON.stringify(data));

Also quick unrelated question, but would it be okay if we always displayed apollo tab?

It should can make an empty Apollo client on debugger for keep the tab, but would be better if we can change apollo-client-devtools behaviors.
}

if (data && (data.__IS_REDUX_NATIVE_MESSAGE__ || data.__REPORT_REACT_DEVTOOLS_PORT__)) {
Expand Down

0 comments on commit bf1e92c

Please sign in to comment.