Use showMessageBoxSync instead of showMessageBox (API breaking change…

…s), related to #408
jhen0409 · Oct 19, 2019 · d6a4605 · d6a4605
1 parent f6dc597
commit d6a4605
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/electron/menu/util.js b/electron/menu/util.js
@@ -13,7 +13,7 @@ const detail = multiline`
 `;
 
 export const showAboutDialog = iconPath =>
-  (remote ? remote.dialog : dialog).showMessageBox({
+  (remote ? remote.dialog : dialog).showMessageBoxSync({
     title: 'About',
     message: `${appName} ${app.getVersion()}`,
     detail,

diff --git a/electron/update.js b/electron/update.js
@@ -10,7 +10,7 @@ const getFeed = () =>
   );
 
 const showDialog = ({ icon, buttons, message, detail }) =>
-  dialog.showMessageBox({
+  dialog.showMessageBoxSync({
     type: 'info',
     buttons,
     title: 'React Native Debugger',
@@ -76,11 +76,13 @@ export default (icon, notify) => {
       notifyUpdateAvailable({ icon, detail })
     ) {
       updater.download();
+      console.log('[RNDebugger] Update downloading...');
     }
     checking = false;
   });
 
   updater.on('update-downloaded', () => {
+    console.log('[RNDebugger] Update downloaded');
     if (notifyUpdateDownloaded({ icon })) {
       updater.install();
     }